Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sha256 labels #478

Merged
merged 5 commits into from
Oct 15, 2020
Merged

Update sha256 labels #478

merged 5 commits into from
Oct 15, 2020

Conversation

ruffsl
Copy link
Member

@ruffsl ruffsl commented Oct 13, 2020

@ruffsl ruffsl requested a review from mikaelarguedas October 13, 2020 21:15
@ruffsl
Copy link
Member Author

ruffsl commented Oct 13, 2020

Not sure when patch in e968311 was removed, nor if it's still needed, but I just added it back, as the image template still hadn't removed it.

@ruffsl ruffsl merged commit bc395c9 into master Oct 15, 2020
@ruffsl ruffsl deleted the sha256-labels branch October 15, 2020 23:17
mikaelarguedas
mikaelarguedas reviewed Oct 16, 2020
View reviewed changes
Copy link
Contributor

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure when patch in e968311 was removed, nor if it's still needed, but I just added it back, as the image template still hadn't removed it.

Looks like you added it back only for dashing but that you removed it for eloquent. Is it on purpose ?

ros/eloquent/ubuntu/bionic/images.yaml.em
@@ -43,10 +43,3 @@ images:
- ros-comm
- roscpp-tutorials
- rospy-tutorials
downstream_packages:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not necessary anymore ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the ros_ci.yaml to remember to check which distro's where patched, but only saw noetic being treated as special. Patch re-applied here: #479

ros/eloquent/ubuntu/bionic/ros1-bridge/Dockerfile Show resolved Hide resolved
@ruffsl ruffsl mentioned this pull request Oct 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruffsl @mikaelarguedas